Add mechanism to have a limit on number of pending queries #7603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrjain
commented
Mar 17, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @vvbalaji-dgraph)
dgraph/cmd/increment/increment.go, line 223 at r1 (raw file):
serverLat := cnt.qLatency + cnt.mLatency clientLat := time.Since(txnStart).Round(time.Millisecond) fmt.Printf("[%d] %-17s Counter VAL: %d [ Ts: %d ] Latency: Q %s M %s S %s C %s D %s\n",
overflow
danielmai
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vvbalaji-dgraph)
aman-bansal
pushed a commit
that referenced
this pull request
Apr 7, 2021
…es (#7603) This is useful to avoid blowing up the number of goroutines handling queries, if the user bombards Dgraph with lots of concurrent / asynchronous requests.
OmarAyo
added a commit
that referenced
this pull request
Aug 17, 2021
…pending queries (#7990) * cherry-pick: feat(query): Add mechanism to have a limit on number of pending queries (#7603) This is useful to avoid blowing up the number of goroutines handling queries, if the user bombards Dgraph with lots of concurrent / asynchronous requests. (cherry picked from commit 1450f81) * Set max_pending_queries flag. Fixing up the cherry-pick. Co-authored-by: Manish R Jain <[email protected]> Co-authored-by: Daniel Mai <[email protected]>
mangalaman93
added a commit
to dgraph-io/dgraph-docs
that referenced
this pull request
Jul 31, 2023
For PR hypermodeinc/dgraph#7603 Closes: DGRAPHCORE-278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is