fix(GraphQL): Fix panic when no schema exists for a new namespace (GRAPHQL-1073) #7630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/graphql
vmrajas
approved these changes
Mar 22, 2021
abhimanyusinghgaur
changed the title
aman-bansal
pushed a commit
that referenced
this pull request
Mar 25, 2021
) This PR fixes the issue where if you create a new namespace and run a GraphQL query for the newly created namespace without first applying any GraphQL schema, then you would get a `panic` in alpha. Now, such a query will not result in `panic`, but instead will give back a similar response: ``` { "errors": [ { "message": "Not resolving getAuthor. There's no GraphQL schema in Dgraph. Use the /admin API to add a GraphQL schema" } ] } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where if you create a new namespace and run a GraphQL query for the newly created namespace without first applying any GraphQL schema, then you would get a
panicin alpha.Now, such a query will not result in
panic, but instead will give back a similar response:This change is