-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Query): [Breaking] Return error for illegal math operations. #7631
fix(Query): [Breaking] Return error for illegal math operations. #7631
Conversation
09071e6
to
d0711a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Defer to @ajeetdsouza for the final approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a table with the old and new behaviours of all the math operations we've changed, and notify the docs team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
* Return error if operand for math functions are invalid
If an operand is passed to math operations like log (ln, logbase), sqrt, pow which might result in illegal operation (resulting in NaN) we return 0 instead of an error. This PR fixes that.
Fixes DGRAPH-3150
This change is