fix(Query): Fix cascade pagination with 0 offset. #7636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhaj-shakeel
requested review from
manishrjain,
martinmr,
pawanrawal and
vvbalaji-dgraph
as code owners
abhimanyusinghgaur
approved these changes
Mar 23, 2021
minhaj-shakeel
commented
Mar 23, 2021
There was a problem hiding this comment.
I will create a ticket for it. Will require a huge dataset for writing test.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @manishrjain, @martinmr, @pawanrawal, and @vvbalaji-dgraph)
aman-bansal
pushed a commit
that referenced
this pull request
Mar 25, 2021
danielmai
added a commit
that referenced
this pull request
Jun 3, 2021
This reverts commit 95deb0a. Reverting this commit fixes Alpha panics when using both ordering and @cascade in a query: 2021/06/03 21:27:33 3 0 github.com/dgraph-io/dgraph/x.AssertTruef /ext-go/1/src/github.com/dgraph-io/dgraph/x/error.go:107 github.com/dgraph-io/dgraph/worker.intersectBucket /ext-go/1/src/github.com/dgraph-io/dgraph/worker/sort.go:694 github.com/dgraph-io/dgraph/worker.sortWithIndex /ext-go/1/src/github.com/dgraph-io/dgraph/worker/sort.go:286 github.com/dgraph-io/dgraph/worker.processSort.func2 /ext-go/1/src/github.com/dgraph-io/dgraph/worker/sort.go:518 runtime.goexit /usr/local/go/src/runtime/asm_amd64.s:1371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DGRAPH-3211.
This PR fixes 2 bugs related to the @cascade directive.
1- Pagination was not working with
Offset = 0.2- @cascade directive not working with sort queries.
This change is