fix(restore): append the object path prefix while reading backup #7686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR by @ahsanbarkati did the same fix in release/v21.03: #7669 @NamanJain8 Is this change needed too or just Ahsan's? This PR changes the s3_handler while #7669 changes the backup_handler. |
|
@danielmai, correct that this fix is similar to the fix @ahsanbarkati made on |
|
Oops, you're right, PR #7669 was done on master (I wrote earlier that it was on release/v21.03). Got it, thanks! |
aman-bansal
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DGRAPH-3236
The restore fails on S3 when the object is nested (
s3://s3.us-east-1.amazonaws.com/dgraphbucket/abc/xyz). This PR fixes it.This change is