-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: compilation on 32bit #8895
Conversation
@wmillers Thanks for the PR. Two questions: 1. why are you using a 32 bit machine still? 2. Why does this create problems on a 32 bit machine? |
# github.com/dgraph-io/dgraph/xidmap
..\xidmap\trie.go:38:49: cannot use math.MaxUint32 (untyped int constant 4294967295) as int value in argument to z.NewBuffer(32 << 20, "Trie").WithMaxSize (overflows)
# github.com/dgraph-io/dgraph/worker
..\worker\restore_reduce.go:39:23: cannot use 2 << 30 (untyped int constant 2147483648) as int value in constant declaration (overflows)
..\worker\queue.go:305:42: cannot use math.MaxUint32 (untyped int constant 4294967295) as int value in argument to t.rng.Intn (overflows) The |
Make sense. I am still wondering what machine you are planning to run that is still 32 bit. In any case, just one suggestion to this PR and we would be happy to merge it. Thanks for answering the questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix compilation on 32bit machine