-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vector type to Dgraph #9050
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harshil Goel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
dgraph-bot
added
area/testing
Testing related issues
area/querylang
Issues related to the query language specification and implementation.
area/schema
Issues related to the schema language and capabilities.
area/core
internal mechanisms
go
Pull requests that update Go code
labels
Mar 13, 2024
harshil-goel
force-pushed
the
harshil-goel/vector-type
branch
from
March 14, 2024 08:31
10c4867
to
0d8dd3c
Compare
mangalaman93
requested changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check for coverage for the new changes using unit tests
harshil-goel
force-pushed
the
harshil-goel/vector-type
branch
from
March 14, 2024 14:00
f23bd97
to
54fe3d0
Compare
mangalaman93
requested changes
Mar 14, 2024
mangalaman93
requested changes
Mar 18, 2024
mangalaman93
previously approved these changes
Mar 18, 2024
harshil-goel
force-pushed
the
harshil-goel/vector-type
branch
from
March 19, 2024 06:28
5e66d7b
to
644b055
Compare
mangalaman93
previously approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/core
internal mechanisms
area/querylang
Issues related to the query language specification and implementation.
area/schema
Issues related to the schema language and capabilities.
area/testing
Testing related issues
go
Pull requests that update Go code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.