Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update math parsing function #9053

Merged
merged 15 commits into from
Mar 19, 2024
Merged

Update math parsing function #9053

merged 15 commits into from
Mar 19, 2024

Conversation

harshil-goel
Copy link
Contributor

Title format:

  • Topic(Area): Feature
  • Topic must be one of build|ci|docs|feat|fix|perf|refactor|chore|test
  • Area must be one of acl|audit|backup|badger|cdc|dql|export|graphql|indexing|multi-tenancy|raft|restore|upgrade|zero
    • Add [BREAKING] if it is a breaking change

Body Format:

Description:
Fixes:
Closes:
Docs:

@harshil-goel harshil-goel requested a review from a team as a code owner March 14, 2024 18:17
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Harshil Goel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add unit tests for error cases. A few minor comments, looks good otherwise

dql/math.go Outdated Show resolved Hide resolved
dql/parser.go Outdated Show resolved Hide resolved
dql/parser.go Outdated Show resolved Hide resolved
dql/parser.go Outdated Show resolved Hide resolved
@harshil-goel harshil-goel force-pushed the harshil-goel/vector-dql branch from 838a7a1 to 13adfc1 Compare March 18, 2024 10:41
mangalaman93
mangalaman93 previously approved these changes Mar 18, 2024
@harshil-goel harshil-goel force-pushed the harshil-goel/vector-type branch from 5e66d7b to 644b055 Compare March 19, 2024 06:28
@harshil-goel harshil-goel force-pushed the harshil-goel/vector-dql branch from 13adfc1 to f0a0bc9 Compare March 19, 2024 06:29
@harshil-goel harshil-goel force-pushed the harshil-goel/vector-dql branch from f0a0bc9 to b5b8387 Compare March 19, 2024 10:41
Base automatically changed from harshil-goel/vector-type to main March 19, 2024 13:11
@mangalaman93 mangalaman93 dismissed their stale review March 19, 2024 13:11

The base branch was changed.

@mangalaman93 mangalaman93 merged commit 5ef9ae6 into main Mar 19, 2024
1 check was pending
@mangalaman93 mangalaman93 deleted the harshil-goel/vector-dql branch March 19, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants