Skip to content

Commit

Permalink
Only set CMAKE_OSX_DEPLOYMENT_TARGET on new macOS
Browse files Browse the repository at this point in the history
We set `CMAKE_OSX_DEPLOYMENT_TARGET` to make the package compatible with
older macOS than the one we're building on.

However, we should not do this when building on an even older system,
e.g. macOS 10.4
  • Loading branch information
glebm committed Nov 15, 2024
1 parent 31c28e7 commit 4ec2492
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ if(APPLE)
set(MACOSX_BUNDLE_REQUIRED_PLATFORM IPhoneOS)
set_target_properties(${BIN_TARGET} PROPERTIES XCODE_ATTRIBUTE_TARGETED_DEVICE_FAMILY "1,2")
set(CMAKE_OSX_DEPLOYMENT_TARGET "9.0")
else()
elseif(DARWIN_MAJOR_VERSION GREATER_EQUAL 16)
set(MACOSX_BUNDLE_REQUIRED_PLATFORM Carbon)
set(CMAKE_OSX_DEPLOYMENT_TARGET "10.12.0")
endif()
Expand Down

0 comments on commit 4ec2492

Please sign in to comment.