Add Crippling Shrines from Hellfire #6273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
viniciusferrao
commented
Jun 26, 2023
viniciusferrao
commented
- Added Murphy's Shrine to the list of Crippling Shrines to be disabled on Hellfire.
- Updated the Options help test about the feature to include Murphy's Shrine.
* Added Murphy's Shrine to the list of Crippling Shrines to be disabled on Hellfire. * Updated the Options help test about the feature to include Murphy's Shrine. Signed-off-by: Vinícius Ferrão <[email protected]>
AJenbo
previously approved these changes
Jun 26, 2023
AJenbo
reviewed
Jun 26, 2023
Signed-off-by: Vinícius Ferrão <[email protected]>
|
This shrine isn't exactly "crippling" like the other ones are, although I guess there is no reason to ever click on it 🤷🏽♂️ |
AJenbo
approved these changes
Jun 26, 2023
|
@AJenbo I have a question regarding translations. This change will break them. I'm a native Portuguese speaker, should I push the changes to the translation also? Or this should/must be a different pull request? |
|
Yeah it would be convenient if you can include the translations for the languages that you are fluent in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.