Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish - Add translations for 2 new lines #7161

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Spanish - Add translations for 2 new lines #7161

merged 1 commit into from
Jun 26, 2024

Conversation

hiperiondev
Copy link
Contributor

No description provided.

@qndel
Copy link
Member

qndel commented Jun 24, 2024

1 commit makes it hard to review - having 1 for syncing with code and 1 for actual changes is much better - now we got 400 lines of changed line numbers and no way to filter that out

@hiperiondev
Copy link
Contributor Author

1 commit makes it hard to review - having 1 for syncing with code and 1 for actual changes is much better - now we got 400 lines of changed line numbers and no way to filter that out

It's true. Would you prefer that I cancel this commit and do it again?

@qndel
Copy link
Member

qndel commented Jun 24, 2024

No need, just keep it in mind for the future + try to make PR title more descriptive as it will end up as the commit message - would be nice to know which language got changed without entering commit's details ;)

@qndel qndel changed the title Complete 2 missing translations Spanish - Add translations for 2 new lines Jun 24, 2024
@AJenbo AJenbo merged commit 251d05d into diasurgical:master Jun 26, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants