Update Polish translations. #7525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks ok, have you checked that new text doesn't go out of bounds if it's longer than previous one? Also not sure about python script, any reason for moving from python to python3? |
|
Sadly the last letter from "Odp. na błyskawice" leaks to the third line. What's your opinion on using "Odp. na błysk." instead to prevent this? Regarding the Python changes: |
Without marking the regular expressions as raw strings Python emits the
following warning:
.../devilutionX/tools/validate_translations.py:24: SyntaxWarning: invalid escape sequence '\d'
if re.search("^{\d+}$", argument) == None:
nelchael
force-pushed
the
translations-polish-update-20241110
branch
from
b3fe044
to
99287bb
Compare
|
Here's a version with
|
|
Now that you've mentioned it... fixing also the "Experience" translation leaking onto next line (also final "e") in 78a018b.
|
|
imo anything is better than having a single letter in a new line 😅 |
qndel
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Please review the following changes for Polish translations.
Synchronizing the
pl.pofile -- this is the large portion of this pull request:Different small updates here and there:
This is potentially controversial -- took the liberty of changing how the resists are labeled on the character screen, in my opinion it looks better, but I'm not going to die on this hill as there seems to be no perfect way of doing that 😞
Some of the above updates are visible in this screenshot comparison:
Before:
After:
