-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use main pdfkit repo #2613
Comments
Hey, regarding png-js bit - consider pngjs too! See my comment: #676 (comment) |
Thanks! Just took a quick look, and pngjs has node deps too, meaning I'll need to fork it as for now, or have them onboard on shipping a browser build. And also convince pdfkit to adopt this. Because pdfkit already uses png-js the path towards unifying this is shorter, but I'll check what would be more convenient |
@foliojs Can you kindly pitch in and add your thoughts here? |
@diegomura Hi! [email protected] D:\alyzone\n-travel-scheduler\n_travel_web_dash error - ./node_modules/fontkit/dist/browser-module.mjs:2:0 Import trace for requested module: https://nextjs.org/docs/messages/module-not-found |
I'd like to remove pdfkit fork and start using https://github.com/foliojs/pdfkit again. I branched from this a long time ago for multiple reasons, so I'm not sure the lift here. It will mean for sure to add several changes in that repo, which I think it could benefit the entire community, but not sure yet what those are.
I'll keep this issue as a sort of umbrella issue where I'll capture all the differences and report progress as I tackle them. It will be a slow path.
The text was updated successfully, but these errors were encountered: