fix: a race condition in useValueRef

DimensionDev · Oct 10, 2019 · bc6004b · bc6004b
1 parent e33cbb0
commit bc6004b
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/utils/hooks/useValueRef.ts b/src/utils/hooks/useValueRef.ts
@@ -3,6 +3,9 @@ import { useState, useEffect } from 'react'
 
 export function useValueRef<T>(ref: ValueRef<T>) {
     const [value, setValue] = useState<T>(ref.value)
-    useEffect(() => ref.addListener(newValue => setValue(newValue)), [ref])
+    useEffect(() => {
+        if (value !== ref.value) setValue(ref.value)
+        return ref.addListener(v => setValue(v))
+    }, [ref, value])
     return value
 }