DDST-271: Feature/deferred search api resolution #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressed with phpcbf: ``` ddev composer exec -- phpcbf --standard=Drupal,DrupalPractice --extensions=php $(ddev drush dd dgi_image_discovery) ```
adam-vessey
commented
Jun 18, 2024
Comment on lines
-8
to
+10
| use Drupal\dgi_image_discovery\DIDImageItemList; | ||
|
|
||
| use Drupal\Core\Entity\EntityTypeInterface; | ||
| use Drupal\Core\Field\BaseFieldDefinition; | ||
| use Drupal\dgi_image_discovery\DIDImageItemList; |
There was a problem hiding this comment.
Largely inconsequential, but should've been in the pre-existing coding standards commit; however, I spec'd the extensions as php, so it didn't touch the .module... whoops! Anyway.
`final` was just there from drush's code generation, but not sure we actually want it there.
Redirect stuff seems to work.
…ch-api-resolution
jordandukart
reviewed
Jul 8, 2024
Could possibly tie-in to the fast 404 stuff, but such isn't configured for use yet in the project.
…lution' into feature/deferred-search-api-resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.