feat: Prefetch page content version objects for faster page tree #418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To improve responsiveness of the page tree for large sites (in terms of pages), this PR adds a
prefetch_related
to the admin query sets and evaluates prefetched version objects where available.This, for example, removes the N+1 issue when getting the state indicators. With a prefetched page content query set evaluating the state indicator does not require a db query.
Note: Currently, the django CMS core does not respect the admin
get_queryset
method which would contain theprefetch_related
rule. This is fixed by django-cms/django-cms#7956Merging of django-cms/django-cms#7956 is required to have a test for this PR.
Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.