Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.rst #424

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Update README.rst #424

merged 3 commits into from
Oct 1, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Sep 21, 2024

Description

The readme did not explain how to create version objects for existing versioned objects.

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun marked this pull request as ready for review September 21, 2024 10:20
@vinitkumar
Copy link
Member

@fsbraun Please have a look at the failing tests?

@vinitkumar vinitkumar merged commit 85b0182 into master Oct 1, 2024
109 checks passed
@fsbraun fsbraun deleted the fsbraun-patch-1 branch October 2, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitkumar vinitkumar vinitkumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsbraun @vinitkumar