Ignore new data coming from Adyen #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm trying to make this Sentry exception (Oscaro employees only) go away. And this "pray it works" PR is the best I can think of. |
| @@ -60,6 +60,7 @@ class Constants: | |||
| SESSION_VALIDITY = 'sessionValidity' | |||
| SKIN_CODE = 'skinCode' | |||
| SHIP_BEFORE_DATE = 'shipBeforeDate' | |||
| ADDITIONAL_DATA = 'additionalData.' | |||
There was a problem hiding this comment.
It looks like none of the other fields have the trailing .. Can we avoid this inconsistency?
There was a problem hiding this comment.
I'll rename to ADDITIONAL_DATA_PREFIX as discussed.
When we migrated our Adyen account to the new 'systems communications' interface, we started getting new data, which caused 500s. As all of it comes in the 'additionalData.KEY = value' format and we don't need it, we just blanket ignore it for now.
maiksprenger
force-pushed
the
feature/additional-data
branch
from
c7686d2
to
d95005f
Compare
|
LGTM. |
maiksprenger
added a commit
that referenced
this pull request
Sep 24, 2015
Ignore new data coming from Adyen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we migrated our Adyen account to the new 'systems communications'
interface, we started getting new data, which caused 500s. As all of it
comes in the
additionalData.KEY = VALUEformat and we don't need it,we just blanket ignore it for now.