Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on iOS 16 beta 3 #25

Closed
GiovanniE1993 opened this issue Jul 14, 2022 · 10 comments
Closed

Crash on iOS 16 beta 3 #25

GiovanniE1993 opened this issue Jul 14, 2022 · 10 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@GiovanniE1993
Copy link

Using a WrappingHStack the iOS app on iOS 16 beta 3 will crash.

To reproduce you can open a view with a WrappingHStack inside.

  • WrappingHStack version: 2.2.1
  • Model: iPad Pro and iPhone XR
  • OS: iOS 16 beta 3
@GiovanniE1993 GiovanniE1993 added bug Something isn't working help wanted Extra attention is needed labels Jul 14, 2022
@dkk dkk removed their assignment Jul 14, 2022
@TDWog411
Copy link

TDWog411 commented Sep 2, 2022

Does WrappingHStack still crash on the current iOS 16 beta?

@ptxmac
Copy link

ptxmac commented Sep 5, 2022

I've swtiched to https://github.com/globulus/swiftui-flow-layout in the meantime, so unfortunately I don't have a project ready to test it

@Nathan-Molby
Copy link

This is still present on the iOS 16 Release Candidate. Looks like any apps that use a WrappingHStack will freeze on iOS 16.

@dkk
Copy link
Owner

dkk commented Sep 8, 2022

I'm on a trip right now, I will try to fix it when I'm back. I would be happy for some help so we can fix the issue sooner.

@TDWog411
Copy link

TDWog411 commented Sep 9, 2022

Thanks for the update. I will avoid using it in my current app.

@rubencodes
Copy link

FWIW same issue on the public iOS 16 release - crash/freeze seems to happen on this line:

let itemWidth = hostingController.view.intrinsicContentSize.width

This is almost certainly an iOS bug, but I wonder if there are any good workarounds...

@dkk dkk self-assigned this Sep 14, 2022
@dkk
Copy link
Owner

dkk commented Sep 15, 2022

I cannot reproduce it, can someone with this problem please share following information:

  • Does it happen on device only or device and simulator?
  • What devices/simulators have you tested?
  • Which Xcode & iOS version where you using?
  • Does the example app crash?
  • Add a minimal, reproducible example

@dkk
Copy link
Owner

dkk commented Sep 15, 2022

This is still present on the iOS 16 Release Candidate. Looks like any apps that use a WrappingHStack will freeze on iOS 16.

It does not seem to be an issue on the final iOS 16 release as far as I can tell, in case someone still has an issue, please reopen stating the information from my previous comment

@dkk dkk closed this as completed Sep 15, 2022
@tomacco
Copy link

tomacco commented Sep 20, 2022

It is happening in our App. So far what I can see is that the closure of GeometryReader in the class WrappingHStack is being called over and over causing the UI to freeze. (Careful, the closure of GeometryReader is being called, not the body of the WrappingHStack struct (which is called the normal amount of times))

Does it happen on device only or device and simulator?

Can't run my project on the simulator because a limitation of one of my dependencies (TensorFlow lite). It is happening on an iPhone 13 Pro with iOS 16.0 (20A362)

What devices/simulators have you tested?

Just one iPhone 13 Pro

Which Xcode & iOS version where you using?

iOS 16.0 (20A362), Xcode 14.0

Does the example app crash?

No

Add a minimal, reproducible example

... Working on it as this is happening in a complex app

@dkk dkk reopened this Sep 20, 2022
@hervenivon
Copy link

It seems this is a minimum reproducible example: #26

@dkk dkk closed this as completed Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

8 participants