Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epitran overwrites global logging object with highest level #154

Open
matgrioni opened this issue Jun 19, 2023 · 0 comments
Open

Epitran overwrites global logging object with highest level #154

matgrioni opened this issue Jun 19, 2023 · 0 comments

Comments

@matgrioni
Copy link

matgrioni commented Jun 19, 2023

In flite.py, which is included in _epitran.py and therefore in __init__.py for the whole package the following line is found:

logging.basicConfig(level=logging.CRITICAL)

This sets the logging for the entire program / module and leads to very surprising behavior and difficulty in debugging. Is there a reason for this call? Ideally it can be removed or replaced with some equivalent that does not impact the overall program level. Really I don't think a library should be setting this type of configuration since the library users will have the context on how the logging should be configured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant