Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential/Proxy is not fully py3 compatible #10912

Closed
belforte opened this issue Dec 6, 2021 · 4 comments · Fixed by #10918
Closed

Credential/Proxy is not fully py3 compatible #10912

belforte opened this issue Dec 6, 2021 · 4 comments · Fixed by #10918
Assignees

Comments

@belforte
Copy link
Member

belforte commented Dec 6, 2021

TypeError: Unicode-objects must be encoded before hashing
in

proxyFilename = os.path.join(self.credServerPath, sha1(
self.userDN + self.vo + self.group + self.role).hexdigest())

@belforte belforte changed the title Credential/Proxy is not fully pyt3 compatible Credential/Proxy is not fully py3 compatible Dec 6, 2021
@belforte
Copy link
Member Author

belforte commented Dec 6, 2021

@mapellidario FYI, this already second glitch we found in current WMCore, shall we start out own branch and merge when @amaltaro is back ? Or i @todor-ivanov comfortable with merging such fixes in current master ?

@todor-ivanov
Copy link
Contributor

Hi @belforte , Thanks for reporting this!

I'll take a look into this ASAP. I feel comfortable enough merging a fix of the sort, the only problem is this is not going to make it for the December release, which is about to be deployed tomorrow.

Do you have a fix already in place or should I work on it myself?

p.s. Just one more thing which is worth keeping in the issue would be a dump of an exception or an error message (in case you have one at hand).

@belforte
Copy link
Member Author

belforte commented Dec 6, 2021

don't worry @todor-ivanov it is a trivial change. It is simply a matter of our branch vs. your master vs. your tag etc. You should leave it to @mapellidario to make PR's

@todor-ivanov
Copy link
Contributor

ok @belforte, waiting for the proper PR then. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants