Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMSMonitoring python package to one that defines heartbeats #11215

Closed
amaltaro opened this issue Jul 14, 2022 · 2 comments · Fixed by #11229
Closed

Update CMSMonitoring python package to one that defines heartbeats #11215

amaltaro opened this issue Jul 14, 2022 · 2 comments · Fixed by #11229

Comments

@amaltaro
Copy link
Contributor

Impact of the bug
WMCore in general

Describe the bug
After we updated the python CMSMonitoring library to 0.6.4 [1] in central services and deployed it in cmsweb (and testbed), Lionel, from CERN IT, reported that we are lacking the heartbeat definition in the STOMP protocol, which is optional according to the official documentation, but a requirement for CERN infrastructure.

The heart-beat option is described here:
https://stomp.github.io/stomp-specification-1.2.html#Heart-beating

and this is the relevant python documentation:
https://jasonrbriggs.github.io/stomp.py/api.html#dealing-with-disconnects

How to reproduce it
Send documents to AMQ using the CMSMonitoring library version 0.6.4

Expected behavior
This has been discussed in a private thread with Ceyhun, Lionel, Valentin, others and we agree that the correct place to make these changes is in the CMSMonitoring (python) package, such that other projects relying on it don't need to reimplement the same thing. mrceyhun is looking into the details and it might be that changes will come with reasonable default values, thus not requiring further changes in WMCore.

Additional context and error message
[1]
#11189

@amaltaro
Copy link
Contributor Author

Ceyhun, please let us know if we can help you with anything here. We should be able to at least run some tests for the upcoming changes.

@amaltaro amaltaro self-assigned this Jul 22, 2022
@amaltaro
Copy link
Contributor Author

The CMSMonitoring team has fixed this issue and released a new version of the Python CMSMonitoring package. This bugfix is now available in PyPi under the version 0.6.5, see PR for further details:
dmwm/CMSMonitoring#155

here is a PR fixing it in the WMCore/cmsdist stack as well:
cms-sw/cmsdist#8002

Given that changes have now been merged in cmsdist, I am closing this issue out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant