Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused encoding parameter in RequestDBWriter.py #12137

Closed
oljemark opened this issue Oct 8, 2024 · 0 comments · Fixed by #12141
Closed

Remove unused encoding parameter in RequestDBWriter.py #12137

oljemark opened this issue Oct 8, 2024 · 0 comments · Fixed by #12141
Assignees

Comments

@oljemark
Copy link
Collaborator

oljemark commented Oct 8, 2024

Impact of the bug
WMCore/Services/RequestDB: The internal variable _propertyNeedToBeEncoded (defined here https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/Services/RequestDB/RequestDBWriter.py#L10 ) is not used anywhere else, and could be removed?

Describe the bug
This variable was used to enumerate (allowed?) keywords that were JSON-encoded instead of saved raw, but the variable stopped being referred to already two weeks later in 2014, in a commit in PR #5550 (commit c21fcb8) , and the choice to encode or not was removed in PR #6006 ,so I'm not sure if adding keyword PriorityTransition to this variable did anything at all in PR #8679 ?

How to reproduce it

Expected behavior
Remove if not used, or in case this whole file is unused?

Additional context and error message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant