Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg to make go install work #1

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Reorg to make go install work #1

merged 2 commits into from
Apr 24, 2024

Conversation

donatj
Copy link
Contributor

@donatj donatj commented Apr 24, 2024

This is a small change, but it allows standard go install to work as expected.

$ go install github.com/dnaeon/makefile-graph/cmd/makefile-graph@latest

See: https://github.com/golang-standards/project-layout/tree/master/cmd

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@dnaeon
Copy link
Owner

dnaeon commented Apr 24, 2024

Hey @donatj ,

Thanks for the PR! Could you also please update the README and add the details about go install ... in it?

This part of the README can be replaced with your example of go install ...

Install the CLI application using go build.

go build -o $(go env GOBIN)/makefile-graph github.com/dnaeon/makefile-graph/cmd

Thanks again!

@donatj
Copy link
Contributor Author

donatj commented Apr 24, 2024

Sure thing! I have updated the README.

@dnaeon dnaeon merged commit 08714cb into dnaeon:v1 Apr 24, 2024
2 checks passed
@dnaeon
Copy link
Owner

dnaeon commented Apr 24, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants