Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update community files #931

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

crazy-max
Copy link
Member

Align community files.

@crazy-max crazy-max requested a review from jedevc August 16, 2023 06:38
@crazy-max crazy-max marked this pull request as ready for review August 16, 2023 06:38
[[email protected]](mailto:[email protected]).

Security reports are greatly appreciated, and we will publicly thank you for it.
We also like to send gifts—if you're into schwag, make sure to let
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We also like to send gifts—if you're into schwag, make sure to let
We also like to send gifts—if you'd like Docker swag, make sure to let

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied this one from https://github.com/docker/buildx/blob/master/.github/SECURITY.md but I think we also have it on other docker repos.

Maybe it would be worth to have a org-wide .github repo and put the SECURITY.md in it so it can be used by all repos across the org? https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/creating-a-default-community-health-file#about-default-community-health-files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I figured it was copied from somewhere. Agree that we should probably have an org-wide thing. You can keep the original text if you want, I just thought it was kind of cringe. I'll add the question about an org-wide .github repo to my backlog to investigate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Code of conduct

- [Moby community guidelines](https://github.com/moby/moby/blob/master/CONTRIBUTING.md#moby-community-guidelines)
- [Docker Code of Conduct](https://github.com/docker/code-of-conduct)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. This repo doesn't seem to be actively updated/maintained, is this still the right thing to point to?

I'd be happy to just point to moby/moby for this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah indeed 😞 I just used the one from buildx repo. We should review that in follow-up. Removing for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit picky idea 🤔

Could we potentially have a make generated-files or similar that generates these markdown files by pulling from buildx? Then we only need to maintain those in one place.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a org-wide .github would be better, see #931 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants