git: wrap upstream gitutil cli #2005
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jedevc
commented
Aug 16, 2023
jedevc
commented
Signed-off-by: Justin Chadwell <[email protected]>
Signed-off-by: Justin Chadwell <[email protected]>
crazy-max
reviewed
Dec 15, 2023
| @@ -94,7 +95,7 @@ func getGitAttributes(ctx context.Context, contextPath string, dockerfilePath st | |||
| } | |||
|
|
|||
| if setGitLabels { | |||
| if root, err := gitc.RootDir(); err != nil { | |||
| if root, err := gitc.WorkTree(ctx); err != nil { | |||
There was a problem hiding this comment.
I think we still need the RootDir func otherwise root will always be empty here.
|
@jedevc I see moby/buildkit#4106 was merged; is this still something to complete? (and a rebase)? |
|
Yeah, ideally this would help remove some of the duplication between buildx and buildkit's custom git logic. Unfortunately, I don't really have any spare cycles at the moment to pick up the rebase - however, I don't think there's anything that's critically changed in buildx for this? So shouldn't be too bad if someone else wants to pick up this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.