-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --pids-limit
flag to docker update
#1765
Conversation
Signed-off-by: Sunny Gogoi <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
ping @tiborvass @vdemeester PTAL |
can add some tests in a follow-up if needed |
Codecov Report
@@ Coverage Diff @@
## master #1765 +/- ##
==========================================
- Coverage 56.32% 56.31% -0.02%
==========================================
Files 307 307
Lines 21177 21181 +4
==========================================
Hits 11928 11928
- Misses 8382 8386 +4
Partials 867 867 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1765 +/- ##
==========================================
- Coverage 56.32% 56.31% -0.02%
==========================================
Files 307 307
Lines 21177 21181 +4
==========================================
Hits 11928 11928
- Misses 8382 8386 +4
Partials 867 867 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completion LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
carry of #181
closes #181
- What I did
Added
pids-limit
flag to dockerupdate
command. Also added completion for bash and zsh.- Description for the changelog
Add
--pids-limit
flag todocker update
Refer: moby/moby#32519