Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --pids-limit flag to docker update #1765

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

thaJeztah
Copy link
Member

carry of #181
closes #181

- What I did

Added pids-limit flag to docker update command. Also added completion for bash and zsh.

- Description for the changelog

Add --pids-limit flag to docker update

Refer: moby/moby#32519

Signed-off-by: Sunny Gogoi <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

ping @tiborvass @vdemeester PTAL

@thaJeztah
Copy link
Member Author

can add some tests in a follow-up if needed

@codecov-io
Copy link

Codecov Report

Merging #1765 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1765      +/-   ##
==========================================
- Coverage   56.32%   56.31%   -0.02%     
==========================================
  Files         307      307              
  Lines       21177    21181       +4     
==========================================
  Hits        11928    11928              
- Misses       8382     8386       +4     
  Partials      867      867

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1765 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1765      +/-   ##
==========================================
- Coverage   56.32%   56.31%   -0.02%     
==========================================
  Files         307      307              
  Lines       21177    21181       +4     
==========================================
  Hits        11928    11928              
- Misses       8382     8386       +4     
  Partials      867      867

Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completion LGTM

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@tonistiigi tonistiigi merged commit dca6d2a into docker:master Mar 21, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.03.0 milestone Mar 21, 2019
@thaJeztah thaJeztah deleted the carry_181_pids_limit branch March 21, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants