macOS credentials not found error apparently changed

[felixfontein]

https://github.com/docker/docker-credential-helpers/blob/master/osxkeychain/osxkeychain_darwin.go contains the hardcoded string The specified item could not be found in the keychain. supposedly returned by SecCopyErrorMessageString (https://github.com/docker/docker-credential-helpers/blob/master/osxkeychain/osxkeychain_darwin.c#L7-L15) when an entry cannot be found in the keychain. Apparently that error message changed to No stored credential for XXX, according to the error messages reported in docker/docker-py#2482.

It would probably better to not rely on magic strings returned by SecCopyErrorMessageString, but instead (also) using the enum values (https://developer.apple.com/documentation/security/1542001-security_framework_result_codes?language=objc), probably this one: errSecItemNotFound.

[crazy-max]

Apparently that error message changed to No stored credential for XXX, according to the error messages reported in docker/docker-py#2482.

This is not related to the osxkeychain store but the plaintext store used in docker-credential-desktop when no credential store is set in the docker config:

return "", "", errors.New("No stored credential for " + serverURL)

So best guess for docker/docker-py#2482 (comment) is this user didn't set any credsStore in ~/.docker/config.json and therefore it fallback to plaintext store.

Suggest to https://github.com/docker/docker-py maintainers to add a new error case for this store.

[crazy-max]

This is not related to the osxkeychain store but the plaintext store used in docker-credential-desktop when no credential store is set in the docker config:

return "", "", errors.New("No stored credential for " + serverURL)

I don't see this implementation anymore in current docker-credential-desktop code base. Looks like it has changed years ago and now directly pass through the underlying credential helper.