Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability add/drop option for creating and updating services #2831

Closed
matusnovak opened this issue Apr 28, 2021 · 2 comments
Closed

Add capability add/drop option for creating and updating services #2831

matusnovak opened this issue Apr 28, 2021 · 2 comments

Comments

@matusnovak
Copy link

Recently the --cap-add option has been added to stack/service commands. Link to the PR: docker/cli#2687

It is done by adding CapabilityAdd and CapabilityDrop into the TaskTemplate -> ContainerSpec within the request body. See here: https://github.com/thaJeztah/cli/blob/master/cli/compose/convert/service.go#L153-L154

At the moment, there is no such option in docker-py when creating services -> https://docker-py.readthedocs.io/en/stable/services.html

@feliperuhland
Copy link
Contributor

Hi @matusnovak

I opened a Pull Request for that feature #2809

@matusnovak
Copy link
Author

Thank you @feliperuhland I will be very glad once that gets merged. I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants