Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[18.09] backport #37771 "vendor: update tar-split" #46

Merged
merged 2 commits into from
Sep 13, 2018

Conversation

kolyshkin
Copy link

@kolyshkin kolyshkin commented Sep 7, 2018

Backport of moby#37771. Fixes moby#37581 for 18.09

git fetch engine
git checkout -b 18.09-backport-pr37771 engine/18.09
git cherry-pick -x b3165f5b2d7c1063c2a76a7ed5c2dd18f868276b
git cherry-pick -x 92e75439037d205c218208945c70cfb3633e87aa
git push kir 18.09-backport-pr37771

Clean cherry-pick, no issues.

Add a test case for creating a 8GB file inside a container.
Due to a bug in tar-split this was failing in Docker 18.06.

The file being created is sparse, so there's not much I/O
happening or disk space being used -- meaning the test is
fast and does not require a lot of disk space.

Signed-off-by: Kir Kolyshkin <[email protected]>
(cherry picked from commit b3165f5)
To include vbatts/tar-split#48 which
fixes the issue of creating an image with >8GB file in it.

Signed-off-by: Kir Kolyshkin <[email protected]>
(cherry picked from commit 92e7543)
@thaJeztah thaJeztah added this to the 18.09.0 milestone Sep 10, 2018
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants