Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: view-only VNC #410

Closed
hellodword opened this issue Apr 24, 2024 · 2 comments
Closed

[Feature]: view-only VNC #410

hellodword opened this issue Apr 24, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@hellodword
Copy link
Contributor

hellodword commented Apr 24, 2024

Is your proposal related to a problem?

I use dockur in GitHub actions to do some E2E tests, with custom win11x64.xml.

I want to observe the status from VNC, while I hope the VNC is view-only because the GitHub actions is public.

Describe the solution you'd like.

I guess it's possible:

https://github.com/novnc/noVNC/blob/9a1b1f0d06567739251314a3b67ac5c432ecad47/docs/EMBEDDING.md?plain=1#L56

I hope there will be a new environment variable to control it:

docker run -e VNC_VIEW_ONLY=yes

Or simply add a new view-only VNC port

Describe alternatives you've considered.

none

Additional context

No response

@hellodword hellodword added the enhancement New feature or request label Apr 24, 2024
@kroese
Copy link
Contributor

kroese commented Apr 24, 2024

The view only mode in noVNC can be only set via the query parameters in the URL. So it provides no security at all, since any visitor can just change the URL in the browser to disable it.

If you want to shield the machine, the quick fix is to change the password for the Docker user in Windows. This way nobody can login, unless you are already logged in Windows yourself (and will likely notice it as soon as somebody else joins).

An even more secure solution would be to enable nginx authentication, that way you cannot even reach the novnc page without password. But this requires a bit more effort to setup, another user created a guide on how to do it: #301 (comment)

@hellodword
Copy link
Contributor Author

Thanks @kroese

can just change the URL in the browser to disable it

Got it.

The nginx way is good for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants