func_get_args() call order fix for HHVM bug

[BenjaminNolan]

Firstly, so no-one closes this as ENOTONMASTER, @Ocramius told me to open it directly against 2.4. :)

This PR fixes bugs in Doctrine\ORM\QueryBuilder where the values provided to method arguments to ::andWhere(), ::orWhere(), ::andHaving(), and ::orHaving() are overwritten by code within the methods in HHVM and PHP7.

After much fun and headscratching in both #doctrine and #hhvm on Freenode, we discovered that in the following code, $where = $this->getDqlPart('where'); overwrites the values stored internally for the $where parameter of the function which is returned by func_get_args():

public function orWhere($where)
{
    $where = $this->getDqlPart('where');
    $args  = func_get_args();
}

This means that instead of $args being set as expected to an array containing the string or object provided to the function, it actually contains the object returned by QueryBuilder::getDqlPart(), which causes all the problems you'd expect it to.

This PR simply swaps the order of the calls so that the function arguments are retrieved via func_get_args() before the $where variable is modified, fixing the problem.

[doctrinebot]

Hello,

thank you for creating this pull request. However did not open it on the "master"
branch. Our Git workflow requires all pull requests to go through "master" branch
and the release masters then merge them back into stable branches, if they are
bug fixes.

Please open the pull request again for the "master" branch and close
this one.

Nevertheless I have opened a Jira ticket for this Pull Request to track this
issue:

http://www.doctrine-project.org/jira/browse/DDC-3317

We use Jira to track the state of pull requests and the versions they got
included in.

[Ocramius]

Related: facebook/hhvm#3816

[Ocramius]

@TwoWholeWorms can you also check if this affects master in any way?

[BenjaminNolan]

By the looks of it, it's already been fixed in all these functions in master (which I'd guess is the 2.5.*-dev tree), so I think the 2.4-only fix should suffice. I could back-port it further, but I highly doubt anyone is using anything earlier than 2.4 on HHVM. Actually, TBH, I highly doubt anyone is using 2.4 on HHVM at all, since it's, y'know… b0rked.

[Ocramius]

Ok, fine with merging then. I'll also tag.

[till]

@Ocramius @TwoWholeWorms — Doesn't look like this fixes much? A test case would have been nice.