Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC-3120 - PHP 5.6 internal classes/Serializable serialization fix #1154

Merged
merged 6 commits into from
Oct 6, 2014

Conversation

Ocramius
Copy link
Member

@Ocramius Ocramius commented Oct 6, 2014

See DDC-3120 ( http://www.doctrine-project.org/jira/browse/DDC-3120 )

This PR provides a backport for the 2.4 branch

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. However did not open it on the "master"
branch. Our Git workflow requires all pull requests to go through "master" branch
and the release masters then merge them back into stable branches, if they are
bug fixes.

Please open the pull request again for the "master" branch and close
this one.

Nevertheless I have opened a Jira ticket for this Pull Request to track this
issue:

http://www.doctrine-project.org/jira/browse/DDC-3339

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius Ocramius changed the title Hotfix/php 5.6 serialization fix DDC-3120 - PHP 5.6 internal classes/Serializable serialization fix Oct 6, 2014
deeky666 added a commit that referenced this pull request Oct 6, 2014
DDC-3120 - PHP 5.6 internal classes/Serializable serialization fix
@deeky666 deeky666 merged commit d46fa4a into doctrine:2.4 Oct 6, 2014
@Ocramius Ocramius deleted the hotfix/PHP-5.6-serialization-fix branch October 6, 2014 13:09
@dbpolito
Copy link

dbpolito commented Dec 3, 2014

Is there any chance this go to v2.3.x? I've tested and this change makes version v2.3.x works at php 5.6.

@Ocramius
Copy link
Member Author

Ocramius commented Dec 3, 2014

@dbpolito we don't even test 2.3 against PHP 5.5 and 5.6: not going to happen unless it's a security issue.

@lyrixx
Copy link
Contributor

lyrixx commented Feb 17, 2015

Hi @Ocramius or @beberlei ; Could you tag a new release with this fix ? Because I want to run my project on php 5.6, and this current release prevent me to do that.

@Ocramius
Copy link
Member Author

This was already tagged in 2.4.6

@lyrixx
Copy link
Contributor

lyrixx commented Feb 17, 2015

Oups, sorry for the noise.

Github did not show me the tag for this commit: a69584a

Thanks anyway ;)

@Ocramius
Copy link
Member Author

@lyrixx consider that we mark the release versions in jira.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants