-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDC-3120 - PHP 5.6 internal classes/Serializable serialization fix #1154
DDC-3120 - PHP 5.6 internal classes/Serializable serialization fix #1154
Conversation
…lass from cached metadata instance
…so with PHP 5.6+
Hello, thank you for creating this pull request. However did not open it on the "master" Please open the pull request again for the "master" branch and close Nevertheless I have opened a Jira ticket for this Pull Request to track this http://www.doctrine-project.org/jira/browse/DDC-3339 We use Jira to track the state of pull requests and the versions they got |
DDC-3120 - PHP 5.6 internal classes/Serializable serialization fix
Is there any chance this go to v2.3.x? I've tested and this change makes version v2.3.x works at php 5.6. |
@dbpolito we don't even test 2.3 against PHP 5.5 and 5.6: not going to happen unless it's a security issue. |
This was already tagged in 2.4.6 |
Oups, sorry for the noise. Github did not show me the tag for this commit: a69584a Thanks anyway ;) |
@lyrixx consider that we mark the release versions in jira. |
See DDC-3120 ( http://www.doctrine-project.org/jira/browse/DDC-3120 )
This PR provides a backport for the 2.4 branch