Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4] Documenting interface methods (based on entity manager) #1191

Merged
merged 3 commits into from
Nov 23, 2014

Conversation

mvar
Copy link

@mvar mvar commented Nov 23, 2014

This PR follows #870 and my comments on it.

I think these changes are MUST for the stable release. Especially when Doctrine is used together with such high quality framework like Symfony.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. However did not open it on the "master"
branch. Our Git workflow requires all pull requests to go through "master" branch
and the release masters then merge them back into stable branches, if they are
bug fixes.

Please open the pull request again for the "master" branch and close
this one.

Nevertheless I have opened a Jira ticket for this Pull Request to track this
issue:

http://www.doctrine-project.org/jira/browse/DDC-3409

We use Jira to track the state of pull requests and the versions they got
included in.

@mvar
Copy link
Author

mvar commented Nov 23, 2014

BTW, this PR won't be closed by me, because of "one exception" in contributing rules.

This undocumented interface such be treated as a bug.

@Ocramius
Copy link
Member

@mvar any reason why this should be backported in 2.4?

@mvar
Copy link
Author

mvar commented Nov 23, 2014

@Ocramius the main reason is that this is needed for autocomplete as I've mentioned before. And because Doctrine 2.5 won't be released soon, this should be backported to 2.4.

Guys, you are doing great job here. Please let community to use this library with joy :)

@Ocramius
Copy link
Member

@mvar just checked and saw that indeed the commits are the same. Merging.

@Ocramius Ocramius self-assigned this Nov 23, 2014
Ocramius added a commit that referenced this pull request Nov 23, 2014
[2.4] Documenting interface methods (based on entity manager)
@Ocramius Ocramius merged commit 3cef0fd into doctrine:2.4 Nov 23, 2014
@mvar mvar deleted the 2.4-hotfix branch November 24, 2014 06:04
@mvar
Copy link
Author

mvar commented Nov 24, 2014

Thank you @Ocramius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants