-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit example of partial indexes #1232
Conversation
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3465 We use Jira to track the state of pull requests and the versions they got |
@PowerKiKi can you split the examples about partial indexes btw? I think they are quite misleading if integrated with "the basics" :-\ |
35ba813
to
3caaf26
Compare
@Ocramius updated the PR as you suggested. Thanks for the feedback. |
Maybe we should add a notice about possible issues using the schema tool to update a schema if the |
I'll wait for the confirmation from @Ocramius, but in that case I would like to avoid duplicating that notice, and centralize everything about partial indexes in a single place. However I don't know where that would best fit... do you have an idea ? could it be at the bottom of that page ? or another page ? |
Don't think so |
Explicit example of partial indexes
Merged, thanks! |
This provide an explicit example of partial indexes annotations. Specifically including all parentheses as returned by PostgreSql.
This is needed following doctrine/dbal#716