-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error undefined index "targetEntity" #1265
Conversation
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3517 We use Jira to track the state of pull requests and the versions they got |
Dang, how did this slip in? @andersonamuller when does this happen for you? Can we have a test case showing the notice? |
Sorry, I don't have much time now for a test case, try this setup: Classes: abstract class Animal
{
protected $id
}
class Cat extends Animal
{
private $sound
}
class Sound
{
private $id
} Mapping /** @var \Doctrine\ORM\Mapping\ClassMetadata $metadata */
$builder = new \Doctrine\ORM\Mapping\Builder\ClassMetadataBuilder($metadata);
$builder->setTable('animal');
$builder->setSingleTableInheritance();
$builder->setDiscriminatorColumn('kind', 'string', 32);
$builder->createField('id', 'binary')->isPrimaryKey()->build(); Mapping /** @var \Doctrine\ORM\Mapping\ClassMetadata $metadata */
$builder = new \Doctrine\ORM\Mapping\Builder\ClassMetadataBuilder($metadata);
$builder->createOneToOne('sound', Sound::class)->fetchLazy()->addJoinColumn('sound_id', 'id', false)->build(); Mapping /** @var \Doctrine\ORM\Mapping\ClassMetadata $metadata */
$builder = new \Doctrine\ORM\Mapping\Builder\ClassMetadataBuilder($metadata);
$builder->setTable('sound');
$builder->createField('id', 'binary')->isPrimaryKey()->build(); |
@andersonamuller I'll try integrating it with the test suite now |
… there is a one-to-one association in a subclass
…es-fix' into hotfix/#1265-sti-persister-one-to-one-association-notices
I integrated tests and merged everything in Thanks @andersonamuller! |
@Ocramius |
No description provided.