Paginator functional tests #1342
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3629 We use Jira to track the state of pull requests and the versions they got |
|
With the changes from #1337, tests on pgsql and mysql pass, and there are 5 failures, and 7 errors on SQL Server. doctrine/dbal#818 resolves all the SQL server failures, and all but 3 of the errors. |
|
A fix to #1337 makes all tests pass on pgsql, mysql, and sql server. Anyone up for testing other platforms? |
|
|
|
Bonus for opening PR #1337: |
|
|
||
| use Doctrine\ORM\ORMException; | ||
|
|
||
| class PaginationException extends ORMException |
There was a problem hiding this comment.
Should probably extend RuntimeException in order to avoid BC breaks.
billschaller
force-pushed
the
paginator-functional-tests
branch
from
07436dd to
afcfea1
Compare
|
@Ocramius fixed all the things |
| } | ||
|
|
||
| /** | ||
| * @expectedException |
There was a problem hiding this comment.
this should be removed give you set it in the test itself
|
@stof fixed per your comments |
…into hotfix/doctrine#1342-paginator-functional-test-integration
…sues' into hotfix/#1342-paginator-functional-test-integration
…sues' into hotfix/#1342-paginator-functional-test-integration
|
Merged together with #1337 |
PaginationTest has been expanded and now covers ordering and limiting rather thoroughly.
4 tests fail on PostgreSQL and MySQL, 14 tests fail on SQL Server, and I didn't try any other DBMS.