Identifier is cached with wrong type #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Id is called with wrong identifier type
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-4016 We use Jira to track the state of pull requests and the versions they got |
|
@guilhermeblanco let me know if this is what you needed to merge! |
guiwoda
force-pushed
the
patch-ddc-3967
branch
from
059f34e to
e2cdf2f
Compare
|
Saw the errors, I'm on it. |
guiwoda
force-pushed
the
patch-ddc-3967
branch
from
e2cdf2f to
58f6e51
Compare
guiwoda
force-pushed
the
patch-ddc-3967
branch
from
58f6e51 to
e3627f1
Compare
guilhermeblanco
added a commit
that referenced
this pull request
Nov 25, 2015
Identifier is cached with wrong type
|
👍 |
|
@Ocramius @guilhermeblanco Will this changes be included any upcoming in 2.5 release? Or is 2.6 coming soon? :) |
|
@janlanger I will backport this to 2.5.4, thanks for poking me :) |
Ocramius
added a commit
that referenced
this pull request
Jan 5, 2016
…t-2-5' into 2.5 Backport #1568 to 2.5
|
Backported in aae43cb |
|
Thanks! |
|
@janlanger and released as 2.5.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1556, just added a functional test that reflects what was described on the original ticket.