Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting minor test case incompatibility with XDebug 2.4.x #5547

Merged
merged 1 commit into from
Dec 11, 2015

Conversation

Ocramius
Copy link
Member

In PHP 5.x + XDebug < 2.4, the output would be "string:..."
In PHP 7.x + XDebug >= 2.4, the output would be "the/file/name.php:11:string:..."

This is an improvement in XDebug that is quite annoying for our purposes, but is actually welcome to most users anyway.

This commit simply fixes that incompatibility

In PHP 5.x + XDebug < 2.4, the output would be "string:..."
In PHP 7.x + XDebug >= 2.4, the output would be "the/file/name.php:11:string:..."

This is an improvement in XDebug that is quite annoying for our purposes, but is actually welcome to most users anyway.

This commit simply fixes that incompatibility
@Ocramius Ocramius added the Bug label Dec 11, 2015
@Ocramius Ocramius self-assigned this Dec 11, 2015
@Ocramius Ocramius added this to the 2.5.3 milestone Dec 11, 2015
Ocramius added a commit that referenced this pull request Dec 11, 2015
…lity-fixes

Correcting minor test case incompatibility with XDebug 2.4.x
@Ocramius Ocramius merged commit 9ac7c3b into master Dec 11, 2015
@Ocramius
Copy link
Member Author

Backported into 2.5 via 65f5777

@Ocramius Ocramius deleted the hotfix/php7-xdebug-incompatibility-fixes branch December 11, 2015 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant