Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach orm:validate-schema to --skip-mapping and --skip-sync #844

Merged
merged 1 commit into from
Jan 2, 2014
Merged

Teach orm:validate-schema to --skip-mapping and --skip-sync #844

merged 1 commit into from
Jan 2, 2014

Conversation

terite
Copy link
Contributor

@terite terite commented Nov 11, 2013

Use --skip-mapping to not check if the current mapping informaiton
is valid or not.

Use --skip-sync to not check if the database schema is in line with
the current schema mapping.

Use --skip-mapping to not check if the current mapping informaiton
is valid or not.

Use --skip-sync to not check if the database schema is in line with
the current schema mapping.
@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2789

We use Jira to track the state of pull requests and the versions they got
included in.

@fprochazka
Copy link
Contributor

👍

@Ocramius
Copy link
Member

I'd rather see new commands that do the single tasks instead...

@Majkl578
Copy link
Contributor

I'd rather see new commands that do the single tasks instead...

👍

@terite
Copy link
Contributor Author

terite commented Nov 12, 2013

I'd rather see commands that do single things too, but since this command already does both, I figured it'd be fine to skip one or the other. It also seems unnecessary to have 3 commands

  • orm:validate-mapping
  • orm:validate-sync
  • orm:validate-schema for both

If that's what will get this through (but with better names, I hope), then I'll happily do the typing required.

@terite
Copy link
Contributor Author

terite commented Nov 20, 2013

I'm looking for a command to validate the schema without checking it against the database. @doctrine, what can I do to get that functionality into Doctrine?

@dcarbone
Copy link

I would welcome this feature as well.

beberlei added a commit that referenced this pull request Jan 2, 2014
Teach orm:validate-schema to --skip-mapping and --skip-sync
@beberlei beberlei merged commit 05576d3 into doctrine:master Jan 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants