lifts an unnecessary restriction on ResultSetMappingBuilder

[schmittjoh]

I've tested this locally, and it seems to work perfectly fine to use the rsm builder when querying for a concrete class (not a potentially abstract base class) in a single-table inheritance scheme.

[doctrinebot]

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2814

We use Jira to track the state of pull requests and the versions they got
included in.

[stof]

Can you add a test covering this to avoid regressions ?

[schmittjoh]

Sure, I was looking for some feedback first though.

On Sun, Nov 24, 2013 at 11:01 AM, Christophe Coevoet <
[email protected]> wrote:

Can you add a test covering this to avoid regressions ?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/858#issuecomment-29152266
.

[Ocramius]

It is not clear to me what case you are covering here. STI works when the selected entity is part of the discriminator map? Are there cases where that wouldn't be true?

[schmittjoh]

Yes, for the base class of the hierarchy.

On Tue, Nov 26, 2013 at 5:48 AM, Marco Pivetta [email protected]:

In lib/Doctrine/ORM/Query/ResultSetMappingBuilder.php:

@@ -179,6 +179,16 @@ protected function addAllClassFields($class, $alias, $columnAliasMap = array())
}
}

• private function isInheritanceSupported(ClassMetadataInfo $classMetadata)
• {

•    if ($classMetadata->isInheritanceTypeSingleTable()
  

•        && in_array($classMetadata->name, $classMetadata->discriminatorMap, true)) {
  

•        return true;
  

It is not clear to me what case you are covering here. STI works when the
selected entity is part of the discriminator map? Are there cases where
that wouldn't be true?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/858/files#r7915280
.

[beberlei]

If this works fine and we can get a test I will merge it.