Allow alternative connection/entity-manager via --em or --conn option

[goetas]

Q	A
Type	bug/feature/improvement
BC Break	no
Fixed issues	#1021 doctrine/DoctrineMigrationsBundle#341

[goetas]

Note for my self: there should be also a config parameter in the configurations allowing you to choose the entity manager or the connection

[AndyDune]

It is very important feature for me.

[goetas]

@SenseException

It's like ConnectionRegistryConnection isn't supposed to be a ConnectionLoader. And the DependencyFactory is already too crowded for implementing new methods there. I have currently no good ideas for this.

Yeah, ideally the connection ConnectionLoader should have a "name", passed as parameter.... I'm not sure if it is backward compatible (yes?) it feels as if the connection should not be part to the dependency factory...

[SenseException]

I'm not sure if it is backward compatible (yes?)

I guess it's not backward compatible, but ConnectionLoader is marked as internal (and probably out of BC promise?) and the classes that are implementing it are declared final. Is there a guide line for such a case?

[goetas]

Hmm... that is a good point... (in reality that makes it confusing, ConnectionLoader probably should not be internal.... since that is how ppl can specify custom connections...)

[goetas]

With 9f75d67 i have refactored how connections are loaded.

The biggest change is the following:

before

/**
 * @internal
 */
interface ConnectionLoader
{
    public function getConnection() : Connection;
}

after

interface ConnectionLoader
{
    public function getConnection(?string $name = null) : Connection;
}

The change is not backward compatible, but given:

• the particularity of the feature
• the fact that was marked as @internal
• the not too high number of downloads

I think that we could discuss the possibility to release it as 3.1 instead of making a new major release just for this change.

What do you think?

cc @greg0ire @SenseException @alcaeus

[greg0ire]

If the changed API was marked as @internal, why are you saying the change isn't backward compatible?

[SenseException]

I guess this is a fitting change for the interface.

ConnectionLoader probably should not be internal.... since that is how ppl can specify custom connections...)

Should the interface stay @internal?

[goetas]

If the changed API was marked as @internal, why are you saying the change isn't backward compatible?

to be honest i got lost and i did not notice that was marked as @internal. IMO it should not have been marked so, but now is convenient.

Should the interface stay @internal?

I think not, if ppl have weird connection setups, that interface is the way how they can provide the connection to the library.

It seems that both of you agree with proceeding with this, I will update tests and documentation by using the currently proposed approach.

[SenseException]

It looks like it.

[goetas]

After a lot of work, this is ready for review!

[goetas]

@andrew-demb @greg0ire You are right, i somehow missed that. Thanks!

[goetas]

All suggestions have been applied.