DDC-3434: LimitSubqueryOutputWalker does not retain correct ORDER BY expression fields when dealing with HIDDEN sort fields

[doctrinebot]

Jira issue originally created by user @Ocramius:

As per discussion in DDC-3336, the Doctrine\ORM\Tools\Pagination\LimitSubqueryOutputWalker does not retain the correct fields in the ORDER BY condition when one of the selected fields is marked as HIDDEN.

As an example, take a DQL query like:

SELECT a, a.name AS HIDDEN ord FROM Doctrine\Tests\ORM\Tools\Pagination\Author a ORDER BY ord DESC

This will result in an SQL query like:

SELECT DISTINCT id*0 FROM (SELECT a0_.id AS id_0, a0_.name AS name_1, a0_.name AS name_2 FROM Author a0_ ORDER BY name_2 DESC) dctrn*result

Removing the HIDDEN modifier will cause the query to produce the correct SQL:

SELECT DISTINCT id*0, name_2 FROM (SELECT a0_.id AS id_0, a0_.name AS name_1, a0_.name AS name_2 FROM Author a0_ ORDER BY name_2 DESC) dctrn_result ORDER BY name*2 DESC

[doctrinebot]

• depends on DDC-3435: [GH-1211] DDC-3434 - paginator ignores HIDDEN fields in ORDER BY query
• relates to DDC-3336: Undefined property: Doctrine\ORM\Query\AST\SimpleArithmeticExpression::$field
• relates to DDC-1958: pager produces wrong results on postgresql

[doctrinebot]

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1210] was closed:
#1210

[doctrinebot]

Issue was closed with resolution "Fixed"