DDC-3606: [GH-1325] fixed PostgreSQL and Oracle pagination issues

[doctrinebot]

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of vaheshadunts:

Url: #1325

Message:

Pagination with ordering on 1:m and m:m relations, was not working
properly because of selecting the ordered fields in main select
statement with distinction (e.g. SELECT DISTINCT e0_.id, p1_.name from
... ) in this case we've received less rows than we've required in
query. So I've modified the subquery generation part.
In case of PostgreSQL and Oracle added the row_number in the subquery
over order by statement, then the main select is grouped by id and
selected min of row number, also ordering by rownumber asc, because they
are on right order already (e.g. select e0_.id, min(rownum) as rownum
from ..... order by rownum).
In case of MySQL, the subselect result with ids are in right order so
there is no need to select that fields(this fixes the same issue too)
In other cases I haven't tested because of that leaved the same.

[doctrinebot]

• depends on DDC-3623: [GH-1337] Paginator OrderBy fix take 2
• depends on DDC-3629: [GH-1342] Paginator functional tests

[doctrinebot]

Comment created by vaheshadunts:

Hi Benjamin Eberlei, please let me know if I need to change something, I've used regular expression to change the doctrine's generated select statement, if there is a better way please let me know.

The code I've modified
https://github.com/vaheshadunts/doctrine2/blob/[DDC-1958](http://www.doctrine-project.org/jira/browse/DDC-1958)/lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php#L221

[doctrinebot]

Comment created by vaheshadunts:

Also please let me know should I have to modify the test assertions of the queries which are have changed by my modifications? Or I have to skip the continuous integration ?

[doctrinebot]

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1325] was labeled:
#1325

[doctrinebot]

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1325] was labeled:
#1325

[doctrinebot]

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1325] was assigned:
#1325

[doctrinebot]

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1325] was unlabeled:
#1325

[doctrinebot]

Issue was closed with resolution "Fixed"