-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match namespace in XML file with namespace in XSD file #10828
Conversation
In 7fa3e6e, a global search and replace was used for http and https. This broke the documentation examples in that as soon as you turn on XSD validation, it will fail because the namespace in the XML file does not match the ones defined in the XSD file, which do not exhibit the https. Note that this is not a security concern, because these URIs are not meant to be actually resolved, but to serve as a unique identifier for the namespace in which we define our elements.
The docs job error should be handled by #10824 and phpDocumentor/guides#486 |
Is there a way to actually migrate towards HTTPS? I understand that the documentation is not correct, but it feels like it should be. 🙈 |
Why would we want to? If you browse the URLs modified here, you will get 404s. They're not really URLs, they're more like unique identifiers that mention |
What about differences in XSD files
There are pointing to different protocols (HTTP/HTTPS) Also opening unsecured |
Maybe the best would be to use orm/lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php Lines 1005 to 1007 in ec7a8a7
So I think the only thing calling https://www.doctrine-project.org/schemas/orm/doctrine-mapping.xsd might be IDEs, but I use Neovim without a plugin doing such a thing, so I wouldn't know. I wonder what is happening for PHPStorm users. Are they getting errors about invalid XML files? |
In #8791, a global search and replace was used for http and https.
This broke the documentation examples in that as soon as you turn on XSD validation, it will fail because the namespace in the XML file does not match the ones defined in the XSD file, which do not exhibit the https.
Note that this is not a security concern, because these URIs are not meant to be actually resolved, but to serve as a unique identifier for the namespace in which we define our elements.