Support fetching entities by aliased name #1181
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3385 We use Jira to track the state of pull requests and the versions they got |
| @@ -18,6 +18,7 @@ | |||
| "doctrine/collections": "~1.2", | |||
| "doctrine/dbal": ">=2.5-dev,<2.6-dev", | |||
| "doctrine/instantiator": "~1.0.1", | |||
| "doctrine/common": ">=2.5-dev,<2.6-dev", | |||
There was a problem hiding this comment.
Not sure why this wasn't there: we depend on the package, therefore it must be in the list.
| /** | ||
| * Retrieve associated ClassMetadata. | ||
| * | ||
| * @return \Doctrine\ORM\Mapping\ClassMetadataInfo |
There was a problem hiding this comment.
This actually returns string, no? If so, the description is also wrong here.
|
|
||
| $this->evm->dispatchEvent(Events::onClassMetadataNotFound, $eventArgs); | ||
|
|
||
| // @todo to be discussed: event is used as a mutable data vector here, which may be undesired. |
There was a problem hiding this comment.
@beberlei I'd like your input on this one if possible
…r hooking into failed `ClassMetadata` loading
…y resolved `ClassMetadata` as a mutable event result vector
…licate imports (caused by rebase conflicts)
…ssed/cleared
…ewly introduced tests
…nterface-first fetching of metadata (via fallback logic)
Ocramius
force-pushed
the
feature/#385-support-fetching-entities-by-aliased-name
branch
from
963d5cd to
06f256b
Compare
…tadataNotFoundEventArgs`
…undEventArgs` from `ManagerEventArgs` instead of generic `EventArgs`
…etadataNotFoundEventArgs` API
…on to new `OnClassMetadataNotFoundEventArgs` API
…ataNotFoundEventArgs` impl
| } | ||
|
|
||
| /** | ||
| * Retrieve associated ClassMetadata. |
There was a problem hiding this comment.
This description is wrong, isn't it?
…EventArgs` docblocks as per @deeky666's review
| @@ -91,6 +92,22 @@ protected function initialize() | |||
| /** | |||
| * {@inheritDoc} | |||
There was a problem hiding this comment.
There is no parent method here as far as I can see. Can you provide a descriptive DocBlock?
There was a problem hiding this comment.
The method is actually an override as per doctrine/common#342
…entities-by-aliased-name Support fetching entities by aliased name
Ocramius
deleted the
feature/#385-support-fetching-entities-by-aliased-name
branch
See #385 (this PR supersedes it)
The final aim is allowing something like:
This PR depends also on doctrine/common#342