From 436fc0e84b42834870beed50387c8531d6674325 Mon Sep 17 00:00:00 2001 From: Roman Bukin Date: Mon, 11 Mar 2024 03:27:52 +0300 Subject: [PATCH 1/3] A Trim() call has been added before parsing FIDO Root certificates due to an error in their production blob. For OneSpan DIGIPASS FX1 BIO (aaguid 30b5035e-d297-4ff1-b00b-addc96ba6a98), one of the base64 strings in the attestationRootCertificates array starts with a tab. --- .../FidoMetadataDecoder/DefaultFidoMetadataDecoder.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/WebAuthn.Net/Services/FidoMetadata/Implementation/FidoMetadataDecoder/DefaultFidoMetadataDecoder.cs b/src/WebAuthn.Net/Services/FidoMetadata/Implementation/FidoMetadataDecoder/DefaultFidoMetadataDecoder.cs index fa7ffa9..fb04ce1 100644 --- a/src/WebAuthn.Net/Services/FidoMetadata/Implementation/FidoMetadataDecoder/DefaultFidoMetadataDecoder.cs +++ b/src/WebAuthn.Net/Services/FidoMetadata/Implementation/FidoMetadataDecoder/DefaultFidoMetadataDecoder.cs @@ -713,7 +713,7 @@ private static bool TryDecodeAttestationRootCertificates(string[] attestationRoo result = new byte[attestationRootCertificates.Length][]; for (var i = 0; i < attestationRootCertificates.Length; i++) { - if (!Base64Raw.TryDecode(attestationRootCertificates[i], out var attestationRootCertificate)) + if (!Base64Raw.TryDecode(attestationRootCertificates[i].Trim(), out var attestationRootCertificate)) { result = null; return false; From 01b26a1b562610bdcf7f045637636b7f99840ef0 Mon Sep 17 00:00:00 2001 From: Roman Bukin Date: Mon, 11 Mar 2024 03:28:25 +0300 Subject: [PATCH 2/3] Bump .NET SDK 8.0.200 => 8.0.201 --- .github/workflows/CI.yml | 2 +- .github/workflows/Release.yml | 2 +- README.md | 2 +- demo/WebAuthn.Net.Demo.FidoConformance/README.md | 2 +- global.json | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index a5fd13a..6b60fff 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -23,7 +23,7 @@ jobs: - name: Setup .NET SDK 8.0 uses: actions/setup-dotnet@v4.0.0 with: - dotnet-version: 8.0.200 + dotnet-version: 8.0.201 source-url: ${{ secrets.NUGET_SOURCE }} env: NUGET_AUTH_TOKEN: ${{ secrets.PACKAGES_TOKEN }} diff --git a/.github/workflows/Release.yml b/.github/workflows/Release.yml index b259204..02c5d5e 100644 --- a/.github/workflows/Release.yml +++ b/.github/workflows/Release.yml @@ -28,7 +28,7 @@ jobs: - name: Setup .NET SDK 8.0 uses: actions/setup-dotnet@v4.0.0 with: - dotnet-version: 8.0.200 + dotnet-version: 8.0.201 source-url: ${{ secrets.NUGET_SOURCE }} env: NUGET_AUTH_TOKEN: ${{ secrets.PACKAGES_TOKEN }} diff --git a/README.md b/README.md index e2ba7cf..1005dc3 100644 --- a/README.md +++ b/README.md @@ -62,7 +62,7 @@ The documentation for each project is described in its README.md file. ### Required dependencies - [.NET SDK 6.0.419+](https://dotnet.microsoft.com/en-us/download/dotnet/6.0) -- [.NET SDK 8.0.200+](https://dotnet.microsoft.com/en-us/download/dotnet/8.0) +- [.NET SDK 8.0.201+](https://dotnet.microsoft.com/en-us/download/dotnet/8.0) ## Tips for Contribution diff --git a/demo/WebAuthn.Net.Demo.FidoConformance/README.md b/demo/WebAuthn.Net.Demo.FidoConformance/README.md index 826d2ea..9707f8f 100644 --- a/demo/WebAuthn.Net.Demo.FidoConformance/README.md +++ b/demo/WebAuthn.Net.Demo.FidoConformance/README.md @@ -16,7 +16,7 @@ This project contains a demo application designed for passing the [FIDO conforma These steps need to be performed only if you have not done them before. -1. Install .NET SDK versions [6.0.419+](https://dotnet.microsoft.com/en-us/download/dotnet/6.0) and [8.0.200+](https://dotnet.microsoft.com/en-us/download/dotnet/8.0). +1. Install .NET SDK versions [6.0.419+](https://dotnet.microsoft.com/en-us/download/dotnet/6.0) and [8.0.201+](https://dotnet.microsoft.com/en-us/download/dotnet/8.0). 2. [Trust the ASP.NET Core HTTPS development certificate](https://learn.microsoft.com/en-us/aspnet/core/security/enforcing-ssl?view=aspnetcore-8.0&tabs=visual-studio%2Clinux-ubuntu#trust-the-aspnet-core-https-development-certificate-on-windows-and-macos) ### Starting the FIDO Conformance test diff --git a/global.json b/global.json index 3c0d167..79a5a3d 100644 --- a/global.json +++ b/global.json @@ -1,6 +1,6 @@ { "sdk": { - "version": "8.0.200", + "version": "8.0.201", "rollForward": "latestFeature", "allowPrerelease": false } From 1cc6f4e583509219b7570aea597f501ea8e9429b Mon Sep 17 00:00:00 2001 From: Roman Bukin Date: Mon, 11 Mar 2024 03:39:05 +0300 Subject: [PATCH 3/3] Bump .NET libs --- .../WebAuthn.Net.Demo.FidoConformance.csproj | 2 +- .../WebAuthn.Net.Storage.MySql.csproj | 4 ++-- .../WebAuthn.Net.Storage.PostgreSql.csproj | 4 ++-- .../WebAuthn.Net.Storage.SqlServer.csproj | 4 ++-- tests/WebAuthn.Net.Tests.Unit/WebAuthn.Net.Tests.Unit.csproj | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/demo/WebAuthn.Net.Demo.FidoConformance/WebAuthn.Net.Demo.FidoConformance.csproj b/demo/WebAuthn.Net.Demo.FidoConformance/WebAuthn.Net.Demo.FidoConformance.csproj index b796cab..bdfe172 100644 --- a/demo/WebAuthn.Net.Demo.FidoConformance/WebAuthn.Net.Demo.FidoConformance.csproj +++ b/demo/WebAuthn.Net.Demo.FidoConformance/WebAuthn.Net.Demo.FidoConformance.csproj @@ -35,7 +35,7 @@ - + diff --git a/src/WebAuthn.Net.Storage.MySql/WebAuthn.Net.Storage.MySql.csproj b/src/WebAuthn.Net.Storage.MySql/WebAuthn.Net.Storage.MySql.csproj index 0c3d6b9..a2f634e 100644 --- a/src/WebAuthn.Net.Storage.MySql/WebAuthn.Net.Storage.MySql.csproj +++ b/src/WebAuthn.Net.Storage.MySql/WebAuthn.Net.Storage.MySql.csproj @@ -26,12 +26,12 @@ - + - + diff --git a/src/WebAuthn.Net.Storage.PostgreSql/WebAuthn.Net.Storage.PostgreSql.csproj b/src/WebAuthn.Net.Storage.PostgreSql/WebAuthn.Net.Storage.PostgreSql.csproj index 603c04c..5bbac57 100644 --- a/src/WebAuthn.Net.Storage.PostgreSql/WebAuthn.Net.Storage.PostgreSql.csproj +++ b/src/WebAuthn.Net.Storage.PostgreSql/WebAuthn.Net.Storage.PostgreSql.csproj @@ -26,12 +26,12 @@ - + - + diff --git a/src/WebAuthn.Net.Storage.SqlServer/WebAuthn.Net.Storage.SqlServer.csproj b/src/WebAuthn.Net.Storage.SqlServer/WebAuthn.Net.Storage.SqlServer.csproj index 31f46e4..be51f92 100644 --- a/src/WebAuthn.Net.Storage.SqlServer/WebAuthn.Net.Storage.SqlServer.csproj +++ b/src/WebAuthn.Net.Storage.SqlServer/WebAuthn.Net.Storage.SqlServer.csproj @@ -22,8 +22,8 @@ - - + + diff --git a/tests/WebAuthn.Net.Tests.Unit/WebAuthn.Net.Tests.Unit.csproj b/tests/WebAuthn.Net.Tests.Unit/WebAuthn.Net.Tests.Unit.csproj index 4f508cc..7238994 100644 --- a/tests/WebAuthn.Net.Tests.Unit/WebAuthn.Net.Tests.Unit.csproj +++ b/tests/WebAuthn.Net.Tests.Unit/WebAuthn.Net.Tests.Unit.csproj @@ -9,13 +9,13 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive - + all runtime; build; native; contentfiles; analyzers; buildtransitive