-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always show navigation on submission pages #5269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Always showing the previous submissions is ok for me
- Showing the score full width is ok for me
- Removing the collapse feature for the score is also ok for me
I agree that the score could used some additional styling, but I'm not sure about reusing the exact style of the feedback table since they look very similar but show something completely different. This might however be a non-issue because the score is only shown on a fraction of the pages.
I do think we can improve of the UI. There is no context right now, just a dump of the score. The user might be confused where this comes from. Can we use a proper title instead of the score? Is there an already used icon we can add? Can we link to a page that shows the rest of this evaluation for that user? Since we have space, maybe also add a text label to the edit button (similar to the debug button)...
Co-authored-by: Bart Mesuere <[email protected]>
Co-authored-by: Bart Mesuere <[email protected]>
This pull request introduces the submission navigation on pages with published scores.
The score is now moved to the next row. It is now expanded by default and no longer toggleable as a student visiting this page will almost always want to see this information.
I made it into a card to help it stand out more. This style is similar to the feedback cards below:
In the card some extra info and a link to the series overview is provided.
On this overview page I also simplified the help texts. I also removed the "feedback" header from the central column, as that might give the impression that that column contains personalized feedback, instead of score item names.
Closes #5268
Side effect: Due to the outlined card style change the login methods on a profile page are also styled differently. But I think its an improvement.
Old:
New: