Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show navigation on submission pages #5269

Merged
merged 14 commits into from
Jan 10, 2024
Merged

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jan 4, 2024

This pull request introduces the submission navigation on pages with published scores.

The score is now moved to the next row. It is now expanded by default and no longer toggleable as a student visiting this page will almost always want to see this information.

I made it into a card to help it stand out more. This style is similar to the feedback cards below:
image
image

In the card some extra info and a link to the series overview is provided.
On this overview page I also simplified the help texts. I also removed the "feedback" header from the central column, as that might give the impression that that column contains personalized feedback, instead of score item names.
image

Closes #5268

Side effect: Due to the outlined card style change the login methods on a profile page are also styled differently. But I think its an improvement.
Old:
image
New:
image

@jorg-vr jorg-vr added the bug Something isn't working label Jan 4, 2024
@jorg-vr jorg-vr self-assigned this Jan 4, 2024
@jorg-vr jorg-vr marked this pull request as ready for review January 4, 2024 14:07
@jorg-vr jorg-vr requested a review from a team as a code owner January 4, 2024 14:07
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team January 4, 2024 14:07
@bmesuere bmesuere added the deploy mestra Request a deployment on mestra label Jan 8, 2024
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Jan 8, 2024
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Always showing the previous submissions is ok for me
  • Showing the score full width is ok for me
  • Removing the collapse feature for the score is also ok for me

I agree that the score could used some additional styling, but I'm not sure about reusing the exact style of the feedback table since they look very similar but show something completely different. This might however be a non-issue because the score is only shown on a fraction of the pages.

I do think we can improve of the UI. There is no context right now, just a dump of the score. The user might be confused where this comes from. Can we use a proper title instead of the score? Is there an already used icon we can add? Can we link to a page that shows the rest of this evaluation for that user? Since we have space, maybe also add a text label to the edit button (similar to the debug button)...

@jorg-vr jorg-vr marked this pull request as draft January 9, 2024 12:58
@jorg-vr jorg-vr marked this pull request as ready for review January 10, 2024 12:48
@jorg-vr jorg-vr requested a review from bmesuere January 10, 2024 12:48
app/views/feedbacks/_score_card.html.erb Outdated Show resolved Hide resolved
config/locales/views/feedbacks/en.yml Outdated Show resolved Hide resolved
config/locales/views/feedbacks/nl.yml Outdated Show resolved Hide resolved
@jorg-vr jorg-vr requested a review from bmesuere January 10, 2024 14:51
@jorg-vr jorg-vr merged commit 024de48 into main Jan 10, 2024
13 checks passed
@jorg-vr jorg-vr deleted the fix/broken-navigation branch January 10, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation not available when submission is evaluated
3 participants