-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically trigger download of exported files #5418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to handle the case where the download doesn't happen or isn't successful? For example, if you have your browser set to ask where a download should be saved and you press cancel, the button still says downloaded, and there is no way I see to download again (except going back through everything).
Hmm, maybe the text should not say 'downloaded', but ready to download We could add a separate 'retry' and 'go back' button Maybe:
|
Co-authored-by: Niko Strijbol <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality-wise, it would make sense to make the waiting/downloading step 3 in the stepper. This, also because:
- the text above the buttons in the action area of the card is a bit strange
- making "go back" the primary action is strange
- next to the automatic download, you also need an explicit button to trigger the download. Some browsers ask for permission to download first, or block such automatic downloads. In such cases, the download would fail.
Great idea. Indeed a big improvement
Is it? I think this is the action everyone would preform after download?
This is what the "retry download" button is for. Is this not clear enough? or do you expect something totally different? |
Co-authored-by: Charlotte Van Petegem <[email protected]>
This pull request simplifies the download process of submission exports.
When a users clicks download after submitting the form, a loading bar will be shown while the backend is preparing the zip. Once this is done, the download is automatically triggered.
A retry button is shown, to use should the automatic download fail. ALso a go back button is added to easily return to the page where you came from.
This pr removes the old page with the index of downloads. This is not seen as a relevant feature for dodona. A user should keep track of their downloads themselves.
I also removed the notification for when a download is ready.
I did some benchmarks and the expected zip speed > 100 submissions per second.
This means that for every normal usecase it should only take a few seconds and never more then a minute.
Downloading all 381 417submissions from Peters programming course does take an hour. If we want to keep async support for these cases, I can revert this.
Part of #3457