Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship evergreen builds by default #64

Closed
matt-gadd opened this issue Feb 28, 2018 · 3 comments
Closed

Ship evergreen builds by default #64

matt-gadd opened this issue Feb 28, 2018 · 3 comments

Comments

@matt-gadd
Copy link
Contributor

At the moment we have to specifically target an evergreen browser to get a build that elides a lot of stuff that is now in all browsers - apart from IE11. We should flip this so we ship an evergreen bundle by default, and offer a legacy flag to build for IE11.

@agubler
Copy link
Member

agubler commented Jul 4, 2018

This is basically done, but at the moment the legacy flag is true by default (as setting to false by default is a breaking change) - will leave open to remind us that we need to flip that for dojo 3.0.0

@JamesLMilner
Copy link
Contributor

@agubler not entirely sure about the internals but just be careful shipping minified ES6 code as there's a known bug on Safari. UglifyJS can get around it but you have to pass in a options flag: mishoo/UglifyJS#1753

@agubler
Copy link
Member

agubler commented Jul 27, 2018

This has been done

@agubler agubler closed this as completed Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants